++1

Brian

> On Jul 26, 2019, at 11:29 AM, Joe Wang <huizhe.w...@oracle.com> wrote:
> 
> +1, and +1 for the salary at the time of JDK 1.1 ;-)
> 
> -Joe
> 
> On 7/26/19 11:17 AM, Lance Andersen wrote:
>> Hi all,
>> 
>> Please review this trivial change for JDK-8226808 which corrects a javadoc 
>> error that dates back to JDK 1.1 where the example for BigDecimal is not 
>> correct:
>> 
>> —————
>> $ hg diff
>> diff -r 550a1a6ca596 
>> src/java.sql/share/classes/java/sql/PreparedStatement.java
>> --- a/src/java.sql/share/classes/java/sql/PreparedStatement.java        Fri 
>> Jul 26 17:15:17 2019 +0000
>> +++ b/src/java.sql/share/classes/java/sql/PreparedStatement.java        Fri 
>> Jul 26 14:13:09 2019 -0400
>> @@ -47,12 +47,13 @@
>>   * <P>
>>   * In the following example of setting a parameter, <code>con</code> 
>> represents
>>   * an active connection:
>> - * <PRE>
>> + * <pre>{@code
>> + *   BigDecimal sal = new BigDecimal("153833.00");
>>   *   PreparedStatement pstmt = con.prepareStatement("UPDATE EMPLOYEES
>>   *                                     SET SALARY = ? WHERE ID = ?");
>> - *   pstmt.setBigDecimal(1, 153833.00)
>> - *   pstmt.setInt(2, 110592)
>> - * </PRE>
>> + *   pstmt.setBigDecimal(1, sal);
>> + *   pstmt.setInt(2, 110592);
>> + * }</pre>
>>   *
>>   * @see Connection#prepareStatement
>>   * @see ResultSet
>> ljanders-mac:open ljanders$
>> ———————
>> 
>> Best,
>> Lance
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
>> Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
>> 
>> 
>> 
> 

Reply via email to