Hi Brian, > On Aug 7, 2019, at 12:21 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > Hi Lance, > > Looks good.
thank you > I was wondering whether you might want to delete the files using > jdk.test.lib.util.FileUtils.deleteFileIfExistsWithRetry() instead. I thought about it but decided it was not needed at least now given the files are only used by this test and the scratch directory will get cleaned up anyways. If you think I should add the library I can, just did not see it warranted at least for now. Just let me know :-) Thank you for the review > > Brian > >> On Aug 6, 2019, at 1:31 PM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >> >> Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8226530 >> <https://bugs.openjdk.java.net/browse/JDK-8226530> >> <https://bugs.openjdk.java.net/browse/JDK-8226530 >> <https://bugs.openjdk.java.net/browse/JDK-8226530>>, where ZipFile does not >> return the correct size from the CEN when the Zip64 Extended Information >> Extra Field is used to store the entry size >> >> The webrev can be found at >> http://cr.openjdk.java.net/~lancea/8226530/webrev.00/index.html >> <http://cr.openjdk.java.net/~lancea/8226530/webrev.00/index.html><http://cr.openjdk.java.net/~lancea/8226530/webrev.00/index.html >> <http://cr.openjdk.java.net/~lancea/8226530/webrev.00/index.html>> >> >> Mach5 jdk tier1-tier3 all pass > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
