Hi Julia, I think you need “@since 14” on the new StrictMath methods. I don’t see any other problems.
Thanks, Brian > On Aug 14, 2019, at 9:01 AM, Julia Boes <julia.b...@oracle.com> wrote: > > This fix adds decrementExact(), incrementExact(), and negateExact() to > java.lang.StrictMath. The methods were added to java.lang.Math previously [1] > and should have been added to java.lang.StrictMath for consistency. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8229485 > <https://bugs.openjdk.java.net/browse/JDK-8229485> > > Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.01/ > <http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.01/> > > CSR: https://bugs.openjdk.java.net/browse/JDK-8229702 > <https://bugs.openjdk.java.net/browse/JDK-8229702>