Thanks, Roger. I will drop all occurrences of "solely" and finalize the CSR.

Naoto

On 9/4/19 1:54 PM, Roger Riggs wrote:
Hi Naoto,

The CSR looks ok.

In Character.java:

In the descriptions mentioning VERTICAL TILDE, I would drop the word "solely".
for example,

* {@code 'VERTICAL TILDE'} is added to {@code Start} for backward
* compatibility.

Overall looks like a good update.

Roger




On 8/29/19 3:42 PM, naoto.s...@oracle.com wrote:
Hi,

Please review the proposed modifications to the methods in java.lang.Character class. The CSR is located here:

https://bugs.openjdk.java.net/browse/JDK-8230188

It mainly intends to clarify the spec of the Unicode Identifier methods, by supplying the corresponding Unicode Standard Annex #31 explanations. Also, it intends to upgrade the current implementation to the latest 12.0 level. Here is the proposed implementation changes:

https://cr.openjdk.java.net/~naoto/8229831/webrev.00/

The CSR is intentionally left as draft so that I can gather/reflect opinions from this list.

Naoto

Reply via email to