Hi,

Thanks for the review, Lance and Brent!

Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.04/


Regards,

Julia

On 23/09/2019 19:58, Lance Andersen wrote:
Hi Julia,

I made a quick pass and the changes seem OK
On Sep 23, 2019, at 2:17 PM, Julia Boes <julia.b...@oracle.com <mailto:julia.b...@oracle.com>> wrote:

Hi Brent,

I was able to generate a webrev without any missing sdiffs (using gawk instead of awk with webrev.ksh) and made the requested changes below.

src/java.base/share/classes/java/util/ResourceBundle.java

I believe the <code> tag spanning L2801-2 can be changed:

2801          * <li>Special cases for Norwegian.  Both <code>Locale("no", "NO", 2802          * "NY")</code> and {@code Locale("nn", "NO")} represent Norwegian

Same at L2818-9:

2818          * Bokmål "nb".  Except for the single case <code>Locale("no", 2819          * "NO", "NY")</code> (handled above), when an input {@code Locale}

The copyright year is now updated where applicable.

Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.03/


Regards,

Julia



<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>



Reply via email to