On 9/25/2019 7:44 AM, Alan Bateman wrote:
On 25/09/2019 15:33, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
These are the code changes to make jpackage an experimental feature.
[1] https://bugs.openjdk.java.net/browse/JDK-8230649
[2] http://cr.openjdk.java.net/~herrick/8230649/webrev.02/
I assume the change to CreateJmods.gmk is not needed as the module
will be resolved because it provides an implementation of ToolProvider.
I was going to point out the same thing as Alan. The rest looks good,
although an explicit informational line in the --help message might be
nice, in case log warnings are going somewhere else.
-- Kevin
