+ // Get indetifier from app image if user
provided app image and
+ // does not provided identifier via CLI.
+ String indentifier =
extractBundleIdentifier(params);
+ if (indentifier != null) {
+ return indentifier;
the variable name and the comment both spell identifier incorrectly
and "does not provided" should be written "did not provide the"
I must be missing something because you seem to be adding a dependency on
the javax.xml module, yet I don't see a "requires" import for that in
the shared
module-info.java or the macos platform extra file.
Oh .. I get it, jdk.jpackage requires java.desktop and it in turn
requires transitive java.xml
because it re-exports some of those APIs.
I don't know that this unrelated use we are making here is really the
intended use of requires transitive,
but I suppose we can address that another day ...
-phil.
On 9/27/19, 8:55 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Removed --identifier option, since it only usage is to specify
identifier when generating pkg on macOS and as default value for
--mac-package-identifier.
- Specifying identifier is no longer needed when generating pkg from
app image and it will be extract from app image by default.
--mac-package-identifier can be used to overwrite default value.
- Removed check for identifier from DMG bundler, since it is not
required by DMG.
[1] https://bugs.openjdk.java.net/browse/JDK-8231281
[2] http://cr.openjdk.java.net/~almatvee/8231281/webrev.00/
Thanks,
Alexander
