Looks fine.
(Sorry to have needed the reminder to respond).
Roger
On 9/27/19 8:25 PM, Brian Burkhalter wrote:
Begin forwarded message:
From: Brian Burkhalter <brian.burkhal...@oracle.com>
Subject: Re: 8229333: java/io/File/SetLastModified.java timed out
Date: September 6, 2019 at 9:36:39 AM PDT
To: core-libs-dev <core-libs-dev@openjdk.java.net>
An alternative would be to increase the required memory:
@@ -23,6 +23,7 @@
/* @test
@bug 4091757 6652379 8177809
+ @requires os.maxMemory >= 16G
@summary Basic test for setLastModified method
*/
Thanks,
Brian
On Aug 28, 2019, at 10:51 AM, Lance Andersen <lance.ander...@oracle.com
<mailto:lance.ander...@oracle.com>> wrote:
Looks fine Brian, fingers crossed the little bugger does not come back :-)
On Aug 27, 2019, at 2:00 PM, Brian Burkhalter <brian.burkhal...@oracle.com
<mailto:brian.burkhal...@oracle.com>> wrote:
The failure reported in [1] was observed to occur on two Mac minis with HDDs.
Given the large file access it is possibly due to slow disk access. The
suggested fix is to increase the timeout [2]. If it is still observed at a
later date a new issue can be filed.
Thanks,
Brian
[1] https://bugs.openjdk.java.net/browse/JDK-8229333
<https://bugs.openjdk.java.net/browse/JDK-8229333>
[2] diff:
@@ -22,11 +22,13 @@
*/
/* @test
- @bug 4091757 6652379 8177809
- @summary Basic test for setLastModified method
+ * @bug 4091757 6652379 8177809
+ * @summary Basic test for setLastModified method
+ * @run main/timeout=180 SetLastModified
*/
-import java.io <http://java.io/>.*;
+import java.io.File;
+import java.io.FileOutputStream;
import java.nio.ByteBuffer;
import java.nio.channels.FileChannel;
<oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
