Hi Severin, The patch looks good to me.
Cheers, Mario On Fri, Sep 27, 2019 at 10:38 AM Severin Gehwolf <sgehw...@redhat.com> wrote: > > Hi! > > I'd appreciate a review of this one. Thanks in advance! See below. > > On Tue, 2019-09-03 at 17:50 +0200, Severin Gehwolf wrote: > > On Mon, 2019-08-26 at 17:54 +0200, Severin Gehwolf wrote: > > > Hi, > > > > > > Please review this 8u backport. The OpenJDK 11u patch does not apply > > > cleanly after path-reshuffeling due to a) test and code for jaxp are > > > split in JDK 8 b) Some rejects in comments - copyright and last > > > modified date. I've omitted rejected comments. I can manually add them > > > if that's preferred. See below. > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213734 > > > webrevs: > > > jdk: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8213734/jdk8/jdk/01/webrev/ > > > jaxp: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8213734/jdk8/jaxp/01/webrev/ > > > > > > Testing: tier1 on Linux x86_64. javax/xml/jaxp tests. New test on > > > Windows without the fix fails and passes with it. > > > > > > Thanks to Simon Tooke who helped testing this patch on Windows. > > > > > > Rejects: > > > $ cat > > > src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java.rej > > > --- XMLEntityManager.java > > > +++ XMLEntityManager.java > > > @@ -1,5 +1,5 @@ > > > /* > > > - * Copyright (c) 2009, 2017, Oracle and/or its affiliates. All rights > > > reserved. > > > + * Copyright (c) 2009, 2018, Oracle and/or its affiliates. All rights > > > reserved. > > > */ > > > /* > > > * Licensed to the Apache Software Foundation (ASF) under one or more > > > @@ -89,7 +89,7 @@ > > > * @author K.Venugopal SUN Microsystems > > > * @author Neeraj Bajaj SUN Microsystems > > > * @author Sunitha Reddy SUN Microsystems > > > - * @LastModified: Oct 2017 > > > + * @LastModified: Nov 2018 > > > */ > > > public class XMLEntityManager implements XMLComponent, XMLEntityResolver > > > { > > > > > > > Gentle reminder. > > Anyone? It's been a month :( > > FWIW, I've updated XMLEntityManager to include the copyright update > upper bound to 2018. The @LastModified lines don't exist in JDK 8u, so > I've omitted that. Latest webrevs: > > webrevs: > jdk: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8213734/jdk8/jdk/01/webrev/ > jaxp: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8213734/jdk8/jaxp/02/webrev/ > > Thanks, > Severin > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
