Thank you Brian for reviewing and reminder.
Updated webrev script and re-generated (no code change compare to
webrev.00):
http://cr.openjdk.java.net/~amlu/8232195/webrev.01
Thanks,
Amy
On 10/15/19 11:33 PM, Brian Burkhalter wrote:
Hi Amy,
This looks OK. It looks like DivisionOverflow was already being run
however.
Also, the navigation in your webrev is broken: is your script current?
Thanks,
Brian
On Oct 14, 2019, at 10:05 PM, Amy Lu <[email protected]
<mailto:[email protected]>> wrote:
test/jdk/java/math/BigInteger/DivisionOverflow.java
test/jdk/java/math/BigInteger/StringConstructorOverflow.java
test/jdk/java/math/BigInteger/SymmetricRangeTests.java
These tests require huge memory and need to run with -Xmx8g
They are skipped or tagged with @ignore and not actually run in
standard testing by jtreg.
Please review the patch to enable them by:
* Adding @requires os.maxMemory > 8g
* Put them into exclusiveAccess.dirs (so they won't run concurrently)
to reduce the risk of impact other test.
Tested on all platforms with small (<8g) or large memory machines.
bug:https://bugs.openjdk.java.net/browse/JDK-8232195
webrev:http://cr.openjdk.java.net/~amlu/8232195/webrev.00/