> On Oct 25, 2019, at 10:10 PM, Jaikiran Pai <jai.forums2...@gmail.com> wrote: > > Thank you for the review, Lance. >
You are very welcome Jaikiran. > On 26/10/19 4:25 AM, Lance Andersen wrote: >> >> The change to Zip FS looks good. I re-worked the test so that it also runs >> against ZipFile (which uses the CEN vs the LOC) and Zip FS in addition to >> ZipInputStream for extra coverage. >> >> The webrev can be found at: >> http://cr.openjdk.java.net/~lancea/8232879/webrev.00/index.html >> <http://cr.openjdk.java.net/~lancea/8232879/webrev.00/index.html>Looks fine. >> A very minor note about >> http://cr.openjdk.java.net/~lancea/8232879/webrev.00/test/jdk/jdk/nio/zipfs/CRCWriteTest.java.html >> >> <http://cr.openjdk.java.net/~lancea/8232879/webrev.00/test/jdk/jdk/nio/zipfs/CRCWriteTest.java.html> > 136 while ((ze = zis.getNextEntry()) != null) { > 137 assertNotNull(ze); > > Looks like an oversight - that assertNotNull(ze) on 137 isn't needed due to > the != null check on 1 Yep, not needed. Sometimes you do things on auto pilot ;-) Will remove before I push the change. > 36. > > -Jaikiran > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
