Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs.frames.html
This file refers to JpAllowDowngrades and JpAllowUpgrades. Code sets
JpAllowUpgrades to yes always and never sets JpAllowDowngrades. Maybe I
am missing something, but why we need these defs in .wxs file if they do
nothing.
Also, I think we should allow downgrades by default.
Thanks,
Alexander
On 11/1/2019 5:06 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally:
- added support for `overrides.wxi` WiX source file in resource dir.
Custom overrides.wxi can be used as a placeholder for overrides of
default WiX variables defined by jpackage that control output msi.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8232919
[2] http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00
