+1,

Thanks

On 11/12/19 4:47 PM, [email protected] wrote:
Hi Roger,

Thank you for your review. The method description was modified per your suggestion:

https://cr.openjdk.java.net/~naoto/8232860/webrev.01/

Naoto

On 11/12/19 1:16 PM, Roger Riggs wrote:
Hi Naoto,

Looks fine.

(You might make the comment clear that makeIntegerFormatter
modifies its argument and returns it. )

Thanks, Roger


On 11/12/19 12:10 PM, [email protected] wrote:
Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8232860

The proposed changeset is located at:

https://cr.openjdk.java.net/~naoto/8232860/webrev.00/

Although this was reported for German locale, it is reproducible on any locale. The root cause of this issue was that the Host adapter for Windows returned the number pattern for number/integer instances, which always require fraction digits, i.e., '0'. Changing it to optional '#' will solve the issue.

Also, I modified the integer formatters to allow only integer processing (used to allow fractions as well).

Naoto


Reply via email to