Hi Brian,
The changes look fine.
In the CSR, the typography of the code font for |java.io.File.getXSpace
|will not read well in all the places where the summary sentence is used
by itself.
Spelling out the names of the affected methods will help.
Having to unpack a zip file to see the changes in the CSR is not reader
friendly.
They are relatively small and could be included inline in the CSR.
Regards, Roger
||
On 11/14/19 10:42 AM, Brian Burkhalter wrote:
Begin forwarded message:
From: Brian Burkhalter <brian.burkhal...@oracle.com>
Subject: 8179320: File.getUsableSpace() returns a negative number on very large
file system
Date: November 1, 2019 at 5:13:28 PM PDT
To: Core-Libs-Dev <core-libs-dev@openjdk.java.net>
For this issue [1], please review this patch [2] and the corresponding CSR [3].
Thanks,
Brian
[1] https://bugs.openjdk.java.net/browse/JDK-8179320
[2] http://cr.openjdk.java.net/~bpb/8179320/webrev.00/
[3] https://bugs.openjdk.java.net/browse/JDK-8233426
