On 16/11/2019 4:38 am, Brent Christian wrote:
On 11/14/19 4:46 PM, Mandy Chung wrote:
On 11/14/19 4:42 PM, David Holmes wrote:

If you really want to test both positive and negative cases from a clean slate then I would suggest modifying the test slightly and using two @run commands - one to try to initialize and one to not.

Yes this is what I was thinking.  Two separate @run commands with an argument to indicate if initialize is true or false would do it.


That sounds good.  Test updated here:
http://cr.openjdk.java.net/~bchristi/8233272/webrev-04/

Minor optimisations:

  35  * @compile MissingClass.java
  36  * @compile Container.java
  37  *
38 * @run main/othervm ClassFileInstaller -jar classes.jar Container Container$1

You can use a single @compile line to compile both classes.

You can use "@run driver" for ClassfileInstaller.

No need to see updated webrev.

Thanks,
David

Thanks,
-Brent

Reply via email to