Hi Christoph / Roger , thanks for the reviews ! Best regards , Matthias
> -----Original Message----- > From: Langer, Christoph <christoph.lan...@sap.com> > Sent: Donnerstag, 21. November 2019 23:13 > To: Roger Riggs <roger.ri...@oracle.com>; core-libs- > d...@openjdk.java.net; Baesken, Matthias <matthias.baes...@sap.com> > Subject: RE: RFR [XS] : 8234339: replace JLI_StrTok in java_md_solinux.c > > +1 > > > -----Original Message----- > > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > > Of Roger Riggs > > Sent: Mittwoch, 20. November 2019 16:08 > > To: core-libs-dev@openjdk.java.net > > Subject: Re: RFR [XS] : 8234339: replace JLI_StrTok in java_md_solinux.c > > > > Hi Matthias, > > > > Good to see the switch to strtok_r. > > Looks fine. > > > > Thanks, Roger > > > > > > On 11/19/19 4:23 AM, Baesken, Matthias wrote: > > > Hello, please review this small change . > > > > > > JLI_StrTok is only used in one function, so the define can be replaced, > > probably we should use the "safer" strtok_r (the MT safety might not be a > > big deal in the launcher however). > > > > > > > > > Bug/webrev : > > > > > > https://bugs.openjdk.java.net/browse/JDK-8234339 > > > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8234339.0/ > > > > > > > > > Thanks, Matthias
