Hi Julia,

looks good to me. 

to make it more consistent w/ other tools, I'd move all ifconfig (incl. one on 
macOS) to 'net' category, i.e. rename them to net.ifconfig, this will require 
also moving all netstat.* on macOS and solaris to 'net' as well. I don't insist 
on it, though. 

-- Igor

> On Nov 28, 2019, at 10:15 AM, Julia Boes <julia.b...@oracle.com> wrote:
> 
> Hi,
> 
> In the case of test failure, the environment information of 'ifconfig -a' is 
> already gathered on macOS systems.
> 
> The following enhancement allows the same information to be gathered on 
> Linux, Solaris and Windows systems (in the latter case 'ipconfig /all').
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234964
> 
> Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8234964/webrev.00/
> 
> Regards,
> 
> Julia
> 

Reply via email to