Hey Igor — please read inlined comment below….. [cc’ed Jon] On Dec 12, 2019, at 10:46 PM, Igor Ignatyev <igor.ignat...@oracle.com<mailto:igor.ignat...@oracle.com>> wrote:
On Dec 12, 2019, at 10:21 PM, David Holmes <david.hol...@oracle.com<mailto:david.hol...@oracle.com>> wrote: Hi Igor, On 13/12/2019 3:19 pm, Igor Ignatyev wrote: https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~iignatyev%2F%2F8235866%2Fwebrev.00&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=e5sMrba8xFcOfBlFXXSSI9zRcZcSIyCQvfmfBtUN8bQ%3D&reserved=0 5 lines changed: 0 ins; 0 del; 5 mod Hi all, could you please review this small patch which updates TEST.ROOT in all test suites to require jtreg4.2b16? 8230067[1] updated profiles to use jtreg4.2b16, but didn't update TEST.ROOT files. this patch forces all users to have jtreg4.2b16, so there will be no difference in how tests are executed locally and in automated testing infrastructures. webrev: https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~iignatyev%2F%2F8235866%2Fwebrev.00&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=e5sMrba8xFcOfBlFXXSSI9zRcZcSIyCQvfmfBtUN8bQ%3D&reserved=0 So you changed everyone to b14 under 8219417 but then jaxp was reverted back to b13 under https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8219705&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=SaI%2Bta5Ug%2BkyKP%2BSJ3iV6HsZHFtZXLU6gTWHXXn%2FyOo%3D&reserved=0 just a few weeks later. Does that mean jaxp has an issue with later jtreg builds? Or was that a mistake? I don't see why 8219705 can require to change requiredVersion, nor do I see it being discussed in RFR (https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openjdk.java.net%2Fpipermail%2Fcore-libs-dev%2F2019-March%2F058923.html&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=tJ74fk0nGaqZ6ROHDYgI96CGeirjKeViQ%2BkkOhWRjN4%3D&reserved=0 <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openjdk.java.net%2Fpipermail%2Fcore-libs-dev%2F2019-March%2F058923.html&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=tJ74fk0nGaqZ6ROHDYgI96CGeirjKeViQ%2BkkOhWRjN4%3D&reserved=0>), so I assume it's just unrelated local changes which got integrated. but just to be safe, @Joe/Lance, were there any reasons why you needed to switch jtreg's requiredVersion back to 4.2b13 in jaxp? are there any reasons which prevent jaxp from switching to jtreg4.2b16 now? Otherwise changes seem fine to me. When was b16 released? the tag was added by Jon on Dec 03 2019. so I believe there was enough time for usual suspects to build/adjust, and I'm aware about at least one publicly available place where people can get the latest build of jtreg, if they have problems w/ building it themselves. This is broken since Dec 3. Do you have a contact ? you may want to let them know. Likely cause: The jerkins build is invoking the build script from the wrong directory. https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ Kumar Thanks, -- Igor Thanks, David JBS: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8235866&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=BIhDQmqlS8eb1i70LoIFYWl5xgLxf9TmsDhLCtkxabw%3D&reserved=0 [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8230067&data=02%7C01%7Ckusrinivasan%40vmware.com%7C8e1128e05e8a441dfd8e08d77f983396%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637118164005266666&sdata=XA0hRPuPrvzK%2B0S25ALE2w1JWUVsUR%2B0ncwbgzpdn3c%3D&reserved=0 Thanks, -- Igor
