The removal of the existing TEST.properties files look fine.

Please also solicit feedback from the security libs team as their area is affected.

Roger, FYI the serial filter tests are updated as part of this changeset.

Cheers,

-Joe

On 12/23/2019 8:13 PM, Igor Ignatyev wrote:
Thanks David.

core-libs folks, could you please review jdk part of this patch?

Thanks,
-- Igor

On Dec 23, 2019, at 1:33 PM, David Holmes <david.hol...@oracle.com> wrote:

Hi Igor,

Hotspot changes seem fine. Can't comment on jdk tests.

Thanks,
David

On 24/12/2019 6:42 am, Igor Ignatyev wrote:
ping?
On Dec 17, 2019, at 11:30 AM, Igor Ignatyev <igor.ignat...@oracle.com> wrote:

http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/
31 lines changed: 20 ins; 11 del; 0 mod;
Hi all,

could you please review this small patch which enables allowSmartActionArgs in 
hotspot and jdk test suites and disables them in a small number of test 
directories? the patch also removes TEST.properties files which enabled 
allowSmartActionArgs as they aren't needed anymore.

from JBS:
currently, allowSmartActionArgs is disabled for the whole hotspot and jdk test 
suites and enabled just in few places. this makes it a bit harder for people to 
use smart action arguments in these test suites as they have to not to forget 
to enable them. and given in all the other test suites, smart action arguments 
are enabled, it can be confusing and frustrating.

testing: tier1-5
JBS: https://bugs.openjdk.java.net/browse/JDK-8236111
webrev: http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/

Thanks,
-- Igor

Reply via email to