On 1/7/2020 4:26 AM, Chris Hegarty wrote:
On 6 Jan 2020, at 23:22, Joe Darcy <joe.da...@oracle.com> wrote: Hello, The initial implementation of java.lang.Record uses a default constructor; an explicit constructor should be added instead. Please review the code change and CSR for this: JDK-8236695: java.lang.Record should be declared with an explicit constructor CSR: https://bugs.openjdk.java.net/browse/JDK-8236699 http://cr.openjdk.java.net/~darcy/8236695.0/LGTM. Some wording could be added about the restriction on the use of this constructor, and its intended audience ( the compiler ), similar to that of Enum(String,int), but equally that could be done separately.
I'll push the current change as-is and leave the spec refinement for future work.
Thanks for the reviews. -Joe
