+1 > On Jan 9, 2020, at 2:22 PM, Joe Darcy <joe.da...@oracle.com> wrote: > > Hello, > > As noted by Werner [1], one of the discussions of the kinds of types in > java.lang.annotation was not updated for records. I checked > java.lang.annotation, java.lang.reflect, and java.lang.Class and found > another location to update: > > JDK-8236877: Add "record" to descriptions in java.lang.{annotation, > reflect} > http://cr.openjdk.java.net/~darcy/8236877.0/ > > I kept long-lines for the review to make review the change easier; I'll > re-flow the text before pushing. > > Patch below; thanks, > > -Joe > > [1] > https://mail.openjdk.java.net/pipermail/compiler-dev/2019-December/014150.html > > > --- old/src/java.base/share/classes/java/lang/Class.java 2020-01-09 > 10:58:53.311010487 -0800 > +++ new/src/java.base/share/classes/java/lang/Class.java 2020-01-09 > 10:58:53.122916487 -0800 > @@ -90,7 +90,7 @@ > > /** > * Instances of the class {@code Class} represent classes and interfaces > - * in a running Java application. An enum type is a kind of class and an > + * in a running Java application. An enum type and a record type are kinds > of class; an > * annotation type is a kind of interface. Every array also > * belongs to a class that is reflected as a {@code Class} object > * that is shared by all arrays with the same element type and number > --- old/src/java.base/share/classes/java/lang/annotation/ElementType.java > 2020-01-09 10:58:53.719214486 -0800 > +++ new/src/java.base/share/classes/java/lang/annotation/ElementType.java > 2020-01-09 10:58:53.543126487 -0800 > @@ -71,7 +71,7 @@ > * @jls 4.1 The Kinds of Types and Values > */ > public enum ElementType { > - /** Class, interface (including annotation type), or enum declaration */ > + /** Class, interface (including annotation type), enum, or record > declaration */ > TYPE, > > /** Field declaration (includes enum constants) */ >
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>