On 1/10/20 10:16 AM, Aleksey Shipilev wrote:
On 1/10/20 7:06 PM, Leonid Mesnik wrote:
I am going to push it in jdk/jdk only and not in jdk14.
I suspect there would be some work around x86_32 before RDP2 hits, so maybe
this can go into
jdk/jdk14 as well? This would minimize the jdk/jdk14 -> jdk/jdk merge chore
next week.
Sure. The test bugs could be fixed during RDP2. So if you feel it is
useful I will push it in jdk14.
Leonid
--- a/test/jdk/java/foreign/TestArrays.java Wed Jan 01 03:08:45 2020 +0100
+++ b/test/jdk/java/foreign/TestArrays.java Fri Jan 10 09:51:51 2020 -0800
@@ -76,8 +76,8 @@
static VarHandle shortHandle = shorts.varHandle(short.class,
PathElement.sequenceElement());
static VarHandle intHandle = ints.varHandle(int.class,
PathElement.sequenceElement());
static VarHandle floatHandle = floats.varHandle(float.class,
PathElement.sequenceElement());
- static VarHandle longHandle = doubles.varHandle(long.class,
PathElement.sequenceElement());
- static VarHandle doubleHandle = longs.varHandle(double.class,
PathElement.sequenceElement());
+ static VarHandle longHandle = longs.varHandle(long.class,
PathElement.sequenceElement());
+ static VarHandle doubleHandle = doubles.varHandle(double.class,
PathElement.sequenceElement());
static void initBytes(MemoryAddress base, SequenceLayout seq, BiConsumer<MemoryAddress, Long> handleSetter) {
for (long i = 0; i < seq.elementCount().getAsLong() ; i++) {
This looks good to me. It does look trivial.