On 10/02/2020 09:04, Claes Redestad wrote:
:

So how about:
http://cr.openjdk.java.net/~redestad/8237878/open.02/

Thanks for restoring the use of Function<String, ClassLoader>. Changing Module::defineClass to invoke a method on ModuleLoaderMap is okay but the method needs to something like "isBuiltinMapper" because it tests if the function is a built-in mapper used for the boot layer (or child layers created when we need to dynamically augment the set of platform modules).

Minor nit but I think the comment on the Mapper constructor would say that it creates a Mapper to map the modules in the given Configuration to the built-in class loaders.

The rest looks good to me.

-Alan

Reply via email to