Hi Bob, On Thu, 2020-02-27 at 15:04 -0500, Bob Vandette wrote: > The updates look fine to me.
Thanks for the review! > Have you scanned through all tests looking for “.length” and [0] to > see if we have any more cases that need updating? I have now and haven't found any places where it's incorrect. There are legit cases which still remain after this patch. Thanks, Severin > Bob. > > > > On Feb 27, 2020, at 2:31 PM, Severin Gehwolf <[email protected]> > > wrote: > > > > Hi, > > > > Could somebody please review those test fixes for the Metrics > > platform > > tests? Some code paths are apparently not being executed on > > "common" > > platforms which didn't make those issues show up earlier :-/ I've > > missed to update some hard-coded values to account for changes done > > via > > JDK-8231111. Matthias Baesken from SAP was kind enough to run this > > through their testing and no more issues show up after this. Much > > appreciated, Matthias! > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8240189 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8240189/01/webrev/ > > > > Testing: Docker tests on Linux x86_64 cgroups v1 and Linux cgroups > > v2 > > (no change). Additional testing done by SAP. All seems to look > > good. > > > > Thoughts? > > > > Thanks, > > Severin > >
