FYI I will be pushing today after one last Mach 5 run completes
-- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com > On Mar 11, 2020, at 8:16 AM, Langer, Christoph <christoph.lan...@sap.com> > wrote: > > > Hi Adam, > > thanks for opening up the bug and reposting. Looks good to me 😊 > > Cheers > Christoph > > From: Adam Sotona <adam.sot...@oracle.com> > Sent: Mittwoch, 11. März 2020 11:32 > To: Langer, Christoph <christoph.lan...@sap.com> > Cc: Lance Andersen <lance.ander...@oracle.com>; Sean Mullan > <sean.mul...@oracle.com>; core-libs-dev@openjdk.java.net > Subject: Re: RFR: 8230117 removing dead code from jar tool > > Hi Christoph, > thank you for clarification, here it is: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8230117 > webrev: http://cr.openjdk.java.net/~asotona/8230117/webrev.00/ > > Mach5 Tier1, Tier2 and Tier3 tests passed. > > Thanks, > Adam > > > On 1 Mar 2020, at 21:16, Langer, Christoph <christoph.lan...@sap.com> wrote: > > Hi Adam, Lance, > > as you've already figured out, attachments sent out to the mailing list will > be removed. So it's important to generate webrevs and link to it or, for > smaller patches, inline it. 😊 > > Also, the RFR subject is missing a bug ID. From the URL to the webrev I take > the bug ID is JDK-8230117. Going to JBS it seems that the bug is > confidential. Could you please either open up the bug before pushing or > alternatively, create a new, public bug to push this against? > > Thanks > Christoph > > > > > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > Of Lance Andersen > Sent: Freitag, 28. Februar 2020 18:04 > To: Sean Mullan <sean.mul...@oracle.com> > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR: removing dead code from jar tool > > sigh it is being removed it appears by the mail server > > I placed a copy here: http://cr.openjdk.java.net/~lancea/JDK-8230117.patch > <http://cr.openjdk.java.net/~lancea/JDK-8230117.patch> > > > On Feb 28, 2020, at 12:00 PM, Lance Andersen > <lance.ander...@oracle.com> wrote: > > > Here it is again > > > On Feb 28, 2020, at 11:07 AM, Sean Mullan <sean.mul...@oracle.com> > wrote: > > > I think you forgot to attach the patch. > > --Sean > > On 2/28/20 2:28 AM, Adam Sotona wrote: > > Hi, > I would like to ask for review of the attached patch removing dead code > from jar tool > > Class files sun.tools.jar.Manifest and sun.tools.jar.SignatureFile appear > to be dead code and should be removed. > > Build with the patch passes all Tier1, Tier2 and Tier3 tests. > Thank you, > Adam > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance > Andersen| Principal Member of Technical Staff | +1.781.442.2037 > > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > > > >
