On 3/11/20 12:21 AM, Yangfei (Felix) wrote:
-----Original Message-----
From: Alan Bateman [mailto:alan.bate...@oracle.com]
Sent: Wednesday, March 11, 2020 3:03 PM
To: Yangfei (Felix) <felix.y...@huawei.com>; core-libs-dev@openjdk.java.net
Subject: Re: RFR(S): 8240734: ModuleHashes attribute not reproducible
between builds
On 11/03/2020 01:11, Yangfei (Felix) wrote:
Thanks for reviewing this. Pushed.
Okay but I think we need to add a test for this. Can you look at
JLinkReproducibleTest and see if it can be extended to use
--keep-packaged-modules so that you have the JMOD files in the run-time
image.
Sure. We will take a look.
I created a JBS issue:
https://bugs.openjdk.java.net/browse/JDK-8240903
I was expecting this fix be pushed when you have added a regression
test. It's okay as it's pushed. Please add one to retrofit that.
Mandy
