Hi Chris, Thanks for taking care of this issue, changes looks OK to me.
I am happy to see that we are removing the lot's of duplicate "DummyServer" from individual test cases and using the "BaseLdapServer" test-server instead. Thanks, Vyom On Fri, Mar 13, 2020 at 1:59 PM Chris Yin <xu.y....@oracle.com> wrote: > Hello, > > Please review following changes to try to fix intermittent failure of test > com/sun/jndi/ldap/RemoveNamingListenerTest.java, thanks > > Bug: https://bugs.openjdk.java.net/browse/JDK-8202117 > Webrev: http://cr.openjdk.java.net/~xyin/8202117/webrev.00/ > > > According to failure logs, test already run done and give a pass message, > but test framework caught “java.lang.RuntimeException: > java.net.SocketException: Connection reset” from other thread during test > end, go through the test code, LDAPServerHandler thread may throw such > exception in specific case. This change will replace test itself > implemented TestLDAPServer/LDAPServerHandler with customized BaseLdapServer > to fix the corner. I had run the changed test on 4 platforms for total 600 > times, no failure observed. > > Thanks, > Chris -- Thanks, Vyom
