Hi Naoto,

EquivMapsGenerator.java: 242
It looks odd to put the warning about being an auto-generated file in the middle of the declarations.
Perhaps add it to the headerText.

The existing maps are not pre-sized, is it important to pre-size the new ones. There's no particular reason to pre-concatinate the new source lines.  Separate writes would be fine too.

Roger

On 3/17/20 4:58 PM, [email protected] wrote:
Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8241082

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8241082/webrev.00/

It is simply updating the data file. Since there is no change in equivalency of language tags, no code change and test change was needed except for the data release date. Instead, I modified the equiv-map source code generator to explicitly specify the initial capacity for hash maps.

Naoto

Reply via email to