Thank you Naoto for the quick update.

Just more findings ...(sorry for not sending earlier)

CoderTest.java
Looks like this test has already been migrated (with enhancement) to the 'open' [1] in JDK-8186801 [2] [3].

I'm not sure whether the data files that used by TestCharsetMapping.java can be leveraged by other two tests, but worth checking.

Thanks,
Amy

[1] http://hg.openjdk.java.net/jdk/jdk/file/tip/test/jdk/sun/nio/cs/TestCharsetMapping.java
[2] https://bugs.openjdk.java.net/browse/JDK-8186801
[3] https://mail.openjdk.java.net/pipermail/nio-dev/2017-August/004427.html


On 3/24/20 12:19 PM, naoto.s...@oracle.com wrote:
Hi Amy,

Good point. Updated.

https://cr.openjdk.java.net/~naoto/8241311/webrev.06/

Naoto

On 3/23/20 7:43 PM, Amy Lu wrote:
Hi, Naoto

CoderTest.java TestConv.java
Should they also include @modules jdk.charsets ?

Thanks,
Amy

On 3/21/20 12:21 AM, naoto.s...@oracle.com wrote:
Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8241311

The proposed changeset is located at:

https://cr.openjdk.java.net/~naoto/8241311/webrev.04/

This is simply to move some test cases that have been in closed repository into open repository.

Naoto


Reply via email to