On 05/04/2020 14:17, David Holmes wrote:
On 4/04/2020 3:13 pm, Henry Jen wrote:
Internal test shows that inline implementation is not working for
some Solaris artifacts, because the -DHAVE_GETHRTIME is not
consistently defined, so it is actually broken. :)
The problem is in defining that function as inline rather than the
-DHAVE_GETHRTIME.
[2020-04-03T15:59:26,981Z] Creating
support/test/hotspot/jtreg/native/bin/jvm-test-launcher from 1 file(s)
The build rules for this special test launcher need to be examined as
something seems wrong to me.
I assume it's just that it's just compiled differently to the regular
launchers and just not noticed that it was missing -DHAVE_GETHRTIME
(unless for anyone to use it with _JAVA_LAUNCHER_DEBUG set). If we go
with Henry's second webrev then I assume -DHAVE_GETHRTIME can be dropped
from LauncherCommon.gmk to avoid confusing any further maintainers in
this area. Also is there a strong need for the non-Solaris getTimeMicros
to have be inline?
-Alan
