Looks good thank you Claes > On Apr 16, 2020, at 11:27 AM, Claes Redestad <claes.redes...@oracle.com> > wrote: > > Lance, > > On 2020-04-16 16:33, Lance Andersen wrote: >> I think this looks good. I few minor comments/suggestions: >> * JavaUtilZipFileAccess.java:Please update the copyright >> * JarFile.java: In getVersionEntry(), can we place break the if >> statements onto two lines to make it a bit easier to rea > * >> ZipFile.java: Perhaps add a comment around *1490* as to why this > code >> was added for future maintainers > > done: http://cr.openjdk.java.net/~redestad/8242596/open.01 > > Thanks! > > /Claes
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
