Hi Alexey,
Looks good.
Thanks,
Alexander
On 4/16/20 10:37 AM, Andy Herrick wrote:
OK - I approve. - I have tested on 2 platforms and it looks good.
/Andy
On 4/15/2020 4:13 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Refactor jpackage native code.
- Improve code reuse between different platforms.
- Replace custom string classes with the standard std::basic_string.
- Merge functionality of libapplauncher.dll(.so) library with
jpackageapplauncher(.exe) binary. There is no point to keep two
different executables.
- Link jpackageapplauncher.exe with MSVC Run-Time library statically
to avoid copying of MSVC Run-Time dlls to app's bin folder.
- Remove unused code.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8242302
[2] http://cr.openjdk.java.net/~asemenyuk/8242302/webrev.00
