> On May 6, 2020, at 9:01 PM, Yumin Qi <yumin...@oracle.com> wrote: > > Hi, > Please review the fix for > bug: https://bugs.openjdk.java.net/browse/JDK-8244495 > webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ > > Tests tools/jlink/JLinkTest.javaand tools/jlink/basic/BasicTest.java failed > after 8237750 pushed. The fix of 8237750 changed default behavior of loading > zip library to on-demand loading. jlink (and jimage) assumes that zip library > was loaded already, so call to FindEntry caused ACCESS_VIOLATION on Windows. > This is a Windows specific problem. GetModuleHandle is used on the library > already loaded and won't load the library if it's not loaded. > > Tests: tier1-2 passed. > > Thanks > Yumin
Looks good.
