Hi Mandy,

> On 14 May 2020, at 21:12, Mandy Chung <mandy.ch...@oracle.com> wrote:
> 
> MethodHandles::privateLookupIn should prepare for being called during early 
> startup when the module of java.base classes are not yet assigned.  This bug 
> is uncovered by panama prototype converting NIO to use memory access API.
> 
> The fix is very simple and move the call to Module::isNamed only if the 
> caller module and target module are different:
> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8244961/webrev.00/

LGTM.

In this case both the caller and target modules are, well.. , null (at this 
point of initialization). So your change should avoid tripping up on this and 
resulting in a NPE.    I am surprised that nothing else has run into this 
before, but the code executed this early on is somewhat limited.

-Chris.

Reply via email to