Claes, I would think CharBuffer would require some testing in your test cases too. Also it looks like some of the CharSequence methods in CharBuffer are declared final. Not sure what is appropriate here as far as CharBuffer::isEmpty modifiers are concerned.
Jason ________________________________________ From: core-libs-dev <[email protected]> on behalf of Claes Redestad <[email protected]> Sent: Tuesday, May 19, 2020 5:37 AM To: Roger Riggs; [email protected] Subject: Re: RFR: 8215401: Add isEmpty default method to CharSequence Hi Roger, sure, added Emptiness.java with a few sanity tests. /Claes On 2020-05-19 00:29, Roger Riggs wrote: > Hi Claes, > > Though it does not look like it could be any simpler, there should > probably be a test. > Checking consistency with the existing implementations of > CharSequence.length() > and a custom subtype. > > Thanks, Roger > > > On 5/18/20 4:48 PM, Claes Redestad wrote: >> Hi, >> >> let's add an isEmpty default method to CharSequence! >> >> Webrev: http://cr.openjdk.java.net/~redestad/8215401/open.00/ >> RFE: https://bugs.openjdk.java.net/browse/JDK-8215401 >> CSR: https://bugs.openjdk.java.net/browse/JDK-8215402 >> >> Testing: tier1-3 >> >> /Claes >
