Hi Stuart,
Looks good.
rmid.properties: 134; avoid breaking "have\n been" in to separate lines.
I would break after the ",".
module-info.java: 35: "version" -> "release" for consistency across the
messages.
package-info.java: 41: "version" -> "release" and "it may" -> "may" to
be consistent
with the wording in other updates.
Does this also need a CSR? (There is one, 8245068, but its all
boilerplate).
Thanks, Roger
On 5/27/20 7:56 AM, Lance Andersen wrote:
Hi Stuart,
I think this looks good. I will add myself as a reviewer for the CSR.
I would probably create an issue for the release note and create a draft I
believe I was asked for that when I was going through my CSR review for removal
of the Java EE modules and CORBA.
Best
Lance
On May 26, 2020, at 3:35 PM, Stuart Marks <[email protected]> wrote:
Hi all,
Here's the implementation of the recently-posted JEP 385, deprecation of RMI
Activation for removal.
I'm listing this as S ("small") since conceptually it's fairly small, though
there are rather a large number of files changed. Essentially the changes are:
- java.rmi.activation package spec: add deprecation warning
- java.rmi module spec: link to activation package spec
- java.rmi.activation public classes and interfaces: deprecate
- various other files: suppress warnings
- Activation.java: have the rmid tool emit a deprecation warning
- rmid.properties: localized warning message
Webrev:
http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.0/
Bug ID:
https://bugs.openjdk.java.net/browse/JDK-8245068
JEP:
http://openjdk.java.net/jeps/385
Thanks,
s'marks
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
