Hi Joe,

I kind of understand your point of being more at ease with the porting itself than with the review.

However, wouldn't a review be needed anyway, regardless how knowledgeable the porter might be? That is, even if an expert like yourself does the port, somebody else would still have to invest time to do the review, I guess, so the overall combined effort would be almost the same. At least, that's my understanding on how development in the OpenJDK works.

Anyway, although I'm not formally a reviewer, just a contributor, I'll be glad to review your code on an informal basis if you need an additional opinion.


Greetings
Raffaello


On 2020-05-27 23:44, Joe Darcy wrote:
Hi Raffaello,

Finishing the fdlibm port remains on my to-do list. Given the review investment needed, I would not find it helpful for someone else to contribute a port.

Thanks,

-Joe

On 5/25/2020 9:24 AM, Raffaello Giulietti wrote:
Hi,

[1] enumerates 14 StrictMath native functions that still need a Java porting from the original C code.

As of changeset b84f122ea855 all of them are still native, so I wonder if it makes sense to contribute or if they have already been ported and on the launch pad for integration.

Let me know.


Greetings
Raffaello

----

[1] https://bugs.openjdk.java.net/browse/JDK-8171407

Reply via email to