Hi Connor, You will want to add the label noreg-doc to the issue before you push for fix
Best Lance > On May 29, 2020, at 6:25 AM, Lance Andersen <lance.ander...@oracle.com> wrote: > > looks fine Connor > >> On May 29, 2020, at 5:37 AM, Conor Cleary <conor.cle...@oracle.com> wrote: >> >> Hi, >> >> Could someone please review my webrev for JDK-8245658 'Arrays.java has two >> occurrences of bad unicode constants in Javadoc.'? >> >> In Arrays.java Javadoc, there were two instances of bad Unicode formatting >> where the null character constant was incorrectly specified with '\u000' >> (another zero is required). This fix displays the correct Unicode constants >> in the Javadoc so that outputted docs display '\u0000'. >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8245658 >> webrev: >> http://cr.openjdk.java.net/~pconcannon/ccleary/8245658/webrevs/webrev.01/ >> >> >> Regards, >> Conor >> > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
