Hi Daniel, Do you still need the SoftReference import given you are no longer using it with memory.add()?
Best Lance > On May 29, 2020, at 11:39 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi, > > I have updated the webrev as suggested by David: > > http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01 > > Unless I hear any objection I'll push that new version if the > tests come back successful. > > best regards, > > -- daniel > > (tier1 and 2 passed, tier5 still running) > > On 29/05/2020 00:36, David Holmes wrote: >>> webrev: >>> http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.00/ >> I would have expected the fix here to be simply to clear memory ie: >> } catch (OutOfMemoryError oome) { >> stop = true; >> memory = null; >> System.gc(); >> } >> Cheers, >> David <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
