On 17/07/2020 12:26, Koichi Sakata wrote: > > > You'll need to find a reviewer that understands what that > > method is supposed to do in that case, that's not me ;-) > > I understand. This ML is suitable for finding a reviewer, isn't it? > Or, there is another way. We can avoid the error by the accepting > maybe-uninitialized warning in libfdlibm instead of fixing k_standard.c.
I think it'd be better to fix it. Although the logic is such that all of the cases are covered by the switch statement in k_standard.c, the default case should return NaN in retval: use zero/zero. I'll approve that. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
