Hi Brian, thanks for your review. I've decided to push into jdk/jdk instead of jdk15. please let me know if you think this patch needs to be in jdk15, and I'll backport it there.
Cheers, -- Igor > On Jul 30, 2020, at 2:39 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > Hi Igor, > > This test looks all right to me. > > Sorry for the late review. > > Thanks, > > Brian > >> On Jul 20, 2020, at 11:28 AM, Igor Ignatyev <igor.ignat...@oracle.com >> <mailto:igor.ignat...@oracle.com>> wrote: >> >> http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 >> <http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00> >>> 98 lines changed: 18 ins; 31 del; 49 mod; >> >> Hi all, >> >> could you please review this small fix to make java/io/File/GetXSpace.java >> work again on windows? >> >> the test has been updated to work under cygwin, which includes the following >> changes: >> - GetXSpace.sh accepts CYGWIN_* as known OS and sets windows path to TMP var >> - uses the same regexp to parse df on windows as on other platforms >> - but uses 'FileSystem' field as Space's name, as opposed to 'MountedOn' on >> *nix, as on cygwin, MountedOn is cygwin path, while FileSystem is >> corresponding windows path, and the test expect Space's name to be >> appropriate path >