Hi Alexey,
Without modifying some logic in Executor, yes stop is needed. After
retryExecutor.stop(); is executed in MacDmgBundler we will still run
command (same with abort), and this command will fail and exception will
be thrown. Stop() is basically like abort, but exception is ignored.
Thanks,
Alexander
On 7/31/20 9:27 AM, Alexey Semenyuk wrote:
Alexander,
Why introduce RetryExecutor.stop() method? Isn't RetryExecutor.abort()
sufficient?
- Alexey
On 7/30/2020 8:10 PM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
- DMG image can get detach even if "hdiutil detach" return resource
busy error. Fixed by stopping trying detach if DMG already got detach.
[1] https://bugs.openjdk.java.net/browse/JDK-8250646
[2] http://cr.openjdk.java.net/~almatvee/8250646/webrev.00/
Thanks,
Alexander
