Hi Raffaello, This looks all right. I would be inclined to do like in [1] and throw the RuntimeException on the line after each readFully() and drop the return statements], but I’m not going to insist on it.
Thanks, Brian [1] http://hg.openjdk.java.net/jdk/jdk/file/db6952bf8c39/test/jdk/java/nio/file/etc/MacVolumesTest.java#l58 > On Aug 6, 2020, at 11:34 AM, Raffaello Giulietti > <raffaello.giulie...@gmail.com> wrote: > > here's the newest patch. > > > Also, instead of using the boolean “caughtException,” we usually just > > put, e.g., the throwing of the RuntimeException on the line after where > > the IIOBE or whatever would be thrown. I don’t think the “finally” block > > is necessary.
