Daniel, Vyom,
Thanks for your reviews
Best Regards,
Aleksei
On 11/08/2020 14:12, Vyom Tiwari wrote:
+1
Vyom
On Tue, Aug 11, 2020 at 4:39 PM Daniel Fuchs <daniel.fu...@oracle.com
<mailto:daniel.fu...@oracle.com>> wrote:
Hi Aleksei,
Looks good to me!
best regards,
-- daniel
On 06/08/2020 13:44, Aleks Efimov wrote:
> Hi,
>
> LdapDnsProviderTest was seen failing due to the timeout caused
by the
> blocked bind operation. That could happen if there is a local
process
> listening on the port specified in the test URL.
> To make LdapProviderTest.ProviderTest.call fail the LDAP connect
timeout
> property needs to be set to greater than 0 value. That will help
> runLocalHostTestWithRandomPort to fail with the timeout
exception if the
> port is busy and try another random port.
> Also, the test output has been modified not to print stack
traces for
> the expected exceptions.
>
> Webrev: http://cr.openjdk.java.net/~aefimov/8251189/00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8251189
>
> The test was executed 100+ times alongside to other LDAP tests
and was
> not seen failing with the
> proposed changes.
>
> With Best Regards,
> Aleksei
>
--
Thanks,
Vyom
