Sorry you are right! Would be nice to have a more general @property for
these types of properties and security properties, etc but that's a
different change ...
--Sean
On 8/14/20 10:18 AM, Daniel Fuchs wrote:
Hi Sean,
Wait wait... Are they system properties really?
Only system properties should be documented with @systemProperty.
I can't find the place were com.sun.jndi.ldap.connect.timeout or
com.sun.jndi.ldap.read.timeout is read from System.
I believe they are just plain environment properties
that you need to specify in the environment map.
best regards,
-- daniel
On 14/08/2020 14:18, Sean Mullan wrote:
On 8/14/20 8:41 AM, Alexey Bakhtin wrote:
Hello Sean,
Thank you for review.
I’ve changed wording and replaced @code with @systemProperty (tested,
it works for module-info.java)
Thanks. Now that you know it works, I think you should change the
other properties documented in that file to @systemProperty to be
consistent. I think it is fine to do that as part of this fix.
--Sean
