This looks ok overall. Not specific to your change but …
I did find it strange that FileHandler had a few methods which listed IllegalArgumentException multiple times (vs. including the possible scenarios for the exception as part of 1 @throws) as I have not noticed that elsewhere in the JDK but perhaps I have missed it. > On Aug 26, 2020, at 12:38 PM, Vipin Sharma <vipinsharm...@gmail.com> wrote: > > Hi, > > Please review and sponsor the fix for replacing @exception with @throws in > java.util.logging package. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8252265 > Webrev: https://cr.openjdk.java.net/~vsharma/8252265/ > > It came up in the below discussion, starting this cleanup with > java.util.logging package. > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068172.html > > Regards, > Vipin Best Lance ------------------ Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
