Roger, Lance, Daniel,
Thanks for your reviews.
With Best Regards,
Aleksei
On 26/08/2020 16:59, Lance Andersen wrote:
+1
On Aug 26, 2020, at 7:46 AM, Aleks Efimov <aleksej.efi...@oracle.com
<mailto:aleksej.efi...@oracle.com>> wrote:
Hi Roger, Lance, Daniel,
Thanks for your reviews and comments!
New webrev with suggested modifications can be viewed at this location:
http://cr.openjdk.java.net/~aefimov/8251182/01
The list of modifications:
- Added @java.io.Serial annotation to 'serialVersionUID' declarations
- Removed trailing periods from @param/@throws
- Added generic first line comments to writeObject/readObject methods
The new version of patch and webrev files have been uploaded to the
CSR issue.
Kind Regards,
Aleksei
On 25/08/2020 20:23, Daniel Fuchs wrote:
Hi Aleksei,
LGTM.
You could also add the @Seial annotation to serialVersionUID
declarations.
best regards,
-- daniel
On 25/08/2020 16:03, Aleks Efimov wrote:
Hi,
The documentation of classes from "java.naming" module needs to be
improved to resolve javadoc -Xdoclint "no comment" warnings.
JBS issue: https://bugs.openjdk.java.net/browse/JDK-8251182
Webrev: http://cr.openjdk.java.net/~aefimov/8251182/00/index.html
CSR: https://bugs.openjdk.java.net/browse/JDK-8252310
With Best Regards,
Aleksei
Best
Lance
------------------
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
