Thanks Joe for your review.
Pushed.
Best regards,
Jie
On 2020/9/4, 12:18 AM, "Joe Wang" <huizhe.w...@oracle.com> wrote:
On 9/3/20 2:51 AM, Alan Bateman wrote:
> On 03/09/2020 10:22, jiefu(傅杰) wrote:
>> Hi all,
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8252740
>> Webrev: http://cr.openjdk.java.net/~jiefu/8252740/webrev.00/
>>
>> After JDK-8252354, properties whose keys or values are none strings
>> won't be skipped any more.
>> Instead, ClassCastException will be thrown.
>>
> Looks like the update to the test is missing from changes for
> JDK-8252354. Your change looks okay but I don't understand why this
> wasn't caught, maybe the test change was in Joe's changes that he tested?
My bad, needed more coffee. I got too used to my routine test script
that covers java.xml, and a bit too eager to get the fix in before the
transition to Git.
The change looks good to me as well.
-Joe
>
> -Alan
