On Fri, 11 Sep 2020 14:17:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review and a sponsor for this patch which fixes the issue > reported in > https://bugs.openjdk.java.net/browse/JDK-8244706? > The commit here sets the `OS` header flag to `255` (which represents > `unknown`) as noted in [1]. A new test has been > included in this commit to verify the change. Furthermore, this doesn't > impact the `java.util.zip.GZIPInputStream` > since it ignores [2] this header value while reading the headers from the > stream. [1] > https://tools.ietf.org/html/rfc1952#page-7 [2] > https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/zip/GZIPInputStream.java#L173 Hi Jaikiran, The change seems fine an inline with the RFC. I can sponsor this once we have another review. I have run the JCK tests for Zip/Gzip/Jar and Mach5 JDK tier1, tier2 and tier3 ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/130
