Hi all, > -----Original Message----- > From: Sean Mullan [mailto:sean.mul...@oracle.com] > Sent: Wednesday, September 9, 2020 12:16 AM > To: Andrew Haley <a...@redhat.com>; Yangfei (Felix) > <felix.y...@huawei.com>; hotspot-compiler-...@openjdk.java.net; core- > libs-...@openjdk.java.net > Cc: aarch64-port-...@openjdk.java.net; Stuart Monteith > <stuart.monte...@linaro.org> > Subject: Re: [aarch64-port-dev ] RFR: 8252204: AArch64: Implement SHA3 > accelerator/intrinsic > > Since this change affects security code, please make sure you add security- > d...@openjdk.java.net on any followup code reviews.
Thanks for reminding that. I have just switched to github and created a PR for this issue: https://github.com/openjdk/jdk/pull/207 Let's switch to this PR for the followup code reviews. I see security and hotspot labels was automatically added by the bots. I also added labels for core-libs and hotspot-compiler. > > On 9/1/20 10:44 AM, Andrew Haley wrote: > > On 01/09/2020 11:53, Yangfei (Felix) wrote: > >> Sure, I am happy if the original author of the assembly code or someone > else from Linaro could help here. > >> I wasn't aware there was such an requirement here given that assembly > code is licensed under GPL. > > > > There sure is. All code must be contributed by its owner and put on > > the cr.openjdk site. Especially GPL code. I have added ard.biesheu...@linaro.org to Contributed-by: in the git commit msg. And the newly created PR was Acked-by: Ard Biesheuvel ard.biesheu...@linaro.org Hope this addresses Andrew's concern. Best regards, Felix
